refactor(hardware): major refactor of hardware modules

system/modules/hardware/backlight/default.nix

@@ -1,16 +0,0 @@
-{ lib, config, ... }:
-
-let
-  cfg = config.systemModules.hardware.backlight;
-  inherit (lib) mkIf mkEnableOption;
-in
-
-{
-  options.systemModules.hardware.backlight = {
-    enable = mkEnableOption "Enable backlight module";
-  };
-  
-  config = mkIf cfg.enable {
-    hardware.brillo.enable = true;
-  };
-}

system/modules/hardware/bluetooth/default.nix

@@ -1,29 +0,0 @@
-{ config, lib, pkgs, ... }:
-
-let
-  cfg = config.systemModules.hardware.bluetooth;
-  inherit (lib) mkIf mkEnableOption;
-in
-
-{
-  options.systemModules.hardware.bluetooth = {
-    enable = mkEnableOption "Enable bluetooth module";
-  };
-
-  config = mkIf cfg.enable {
-
-    hardware.bluetooth = {
-      enable = true;
-      package = pkgs.bluez5-experimental;
-    };
-  
-    environment.systemPackages = with pkgs; [
-    	galaxy-buds-client
-      live-buds-cli
-  	  bluetuith
-  	];
-
-     # https://github.com/NixOS/nixpkgs/issues/114222
-    systemd.user.services.telephony_client.enable = false;
-  };
-}

system/modules/hardware/default.nix

@@ -1,7 +1,8 @@
 {
   imports = [
-    ./bluetooth
-    ./backlight
+    ./cpu
+    ./gpu
+    ./features
     ./ssd
   ];
 }

system/modules/hardware/features/backlight/default.nix

@@ -0,0 +1,13 @@
+{ lib, config, ... }:
+
+let
+  features = config.systemModules.hardware.features;
+  inherit (lib) mkIf;
+  inherit (builtins) elem;
+in
+
+{
+  config = mkIf (elem "backlight" features) {
+    hardware.brillo.enable = true;
+  };
+}

system/modules/hardware/features/battery/default.nix

@@ -0,0 +1,94 @@
+
+{ lib, config, pkgs, ... }:
+
+let
+  features = config.systemModules.hardware.features;
+  cfg = config.systemModules.hardware.battery;
+  inherit (lib) mkIf mkDefault mkOption types;
+  inherit (builtins) elem;
+  MHz = x: x * 1000;
+in
+  
+{
+  options.systemModules.hardware.battery = {
+    powersave = {
+      minFreq = mkOption {
+        type = types.int;
+        default = 800;
+        description = "Minimum frequency for powersave mode in MHz";
+      };
+      maxFreq = mkOption {
+        type = types.int;
+        default = 1100;
+        description = "Maximum frequency for powersave mode in MHz";
+      };
+    };
+    performance = {
+      minFreq = mkOption {
+        type = types.int;
+        default = 1500;
+        description = "Minimum frequency for performance mode in MHz";
+      };
+      maxFreq = mkOption {
+        type = types.int;
+        default = 2600;
+        description = "Maximum frequency for performance mode in MHz";
+      };
+    };
+  };
+
+  config = mkIf (elem "battery" features) {
+    boot = {
+      kernelModules = ["acpi_call"];
+      extraModulePackages = with config.boot.kernelPackages; [
+        acpi_call
+        cpupower
+      ];
+    };
+
+    services = {
+      auto-cpufreq = {
+        enable = true;
+        settings = {
+          battery = {
+            governor = "powersave";
+            scaling_min_freq = mkDefault (MHz cfg.powersave.minFreq);
+            scaling_max_freq = mkDefault (MHz cfg.powersave.maxFreq);
+            turbo = "never";
+          };
+          charger = {
+            governor = "performance";
+            scaling_min_freq = mkDefault (MHz cfg.performance.minFreq);
+            scaling_max_freq = mkDefault (MHz cfg.performance.maxFreq);
+            turbo = "auto";
+          };
+        };
+      };
+
+      upower = {
+        enable = true;
+        percentageLow = 25;
+        percentageCritical = 5;
+        percentageAction = 3;
+        criticalPowerAction = "Hibernate";
+      };
+
+      undervolt = {
+        enable = true;
+        tempBat = 65;
+      };
+
+      thermald.enable = true;
+
+      power-profiles-daemon.enable = true;
+
+      logind = {
+        lidSwitch = "suspend";
+      };
+    };
+    environment.systemPackages = with pkgs; [
+      acpi
+      powertop
+    ];
+  };
+}

system/modules/hardware/features/bluetooth/default.nix

@@ -0,0 +1,24 @@
+{ config, lib, pkgs, ... }:
+
+let
+  features = config.systemModules.hardware.features;
+  inherit (lib) mkIf;
+  inherit (builtins) elem;
+in
+
+{
+  config = mkIf (elem "bluetooth" features) {
+    hardware.bluetooth = {
+      enable = true;
+      package = pkgs.bluez5-experimental;
+    };
+  
+    environment.systemPackages = with pkgs; [
+      live-buds-cli
+  	  bluetuith
+  	];
+
+    # https://github.com/NixOS/nixpkgs/issues/114222
+    systemd.user.services.telephony_client.enable = false;
+  };
+}

system/modules/hardware/features/default.nix

@@ -0,0 +1,19 @@
+{ lib, config, ... }:
+
+let
+  inherit (lib) types mkOption;
+in
+
+{
+  imports = [
+    ./bluetooth
+    ./backlight
+    ./battery
+  ];
+
+  options.systemModules.hardware.features = mkOption {
+    type = with types; listOf (enum ["bluetooth" "backlight" "battery"]);
+    default = [];
+    description = "What extra hardware feature system modules to use";
+  };
+}

system/modules/hardware/gpu/amd/default.nix

@@ -18,12 +18,12 @@ in
         mesa
       ];
       extraPackages32 = [ pkgs.driversi686Linux.amdvlk ];
-      boot = {
-        initrd.kernelModules = ["amdgpu"];
-        kernelModules = ["amdgpu"];
-      };
-      environment.systemPackages = [ pkgs.nvtopPackages.amd ];
-      services.xserver.videoDrivers = mkDefault ["modesetting" "amdgpu"];
     };
+    boot = {
+      initrd.kernelModules = ["amdgpu"];
+      kernelModules = ["amdgpu"];
+    };
+    environment.systemPackages = [ pkgs.nvtopPackages.amd ];
+    services.xserver.videoDrivers = mkDefault ["modesetting" "amdgpu"];
   };
 }

system/modules/hardware/gpu/intel/default.nix

@@ -5,7 +5,7 @@ let
   inherit (lib) mkIf;
   inherit (builtins) elem;
 
-  vaapiIntel = pkgs.vaapiIntel.override {enableHypbridCodec = true;};
+  # vaapiIntel = pkgs.vaapiIntel.override {enableHybridCodec = true;};
 in
 
 {

system/modules/hardware/gpu/nvidia/default.nix

@@ -19,7 +19,7 @@ in
         nvidiaSettings = false;
         nvidiaPersistenced = true;
         modesetting.enable = true;
-        powermanagement = {
+        powerManagement = {
           enable = mkDefault true;
           finegrained = mkDefault false;
         };