refactor(systemModules:shell): move shell module to reflect changes to how user shell is defined

system/modules/shell/bash/default.nix

@@ -2,12 +2,12 @@
 
 let
   inherit (lib) mkIf;
-  userShell = config.systemModules.user.shell;
+  adminShell = config.systemModules.host.admin.shell;
+  cfg = config.systemModules.shell.zsh;
 in
 
 {
-  config = mkIf (userShell == "bash") {
-    users.users.ooks.shell = pkgs.bash;
+  config = mkIf (adminShell == "bash" || cfg.enable) {
     programs.bash = {
       enable = true;
     };

system/modules/shell/default.nix

@@ -0,0 +1,7 @@
+{
+  imports = [
+    ./fish
+    ./bash
+    ./zsh
+  ];
+}

system/modules/shell/fish/default.nix

@@ -0,0 +1,22 @@
+{ lib, config, ... }:
+
+let
+  inherit (lib) mkIf mkEnableOption;
+  adminShell = config.systemModules.host.admin.shell;
+  cfg = config.systemModules.shell.fish;
+in
+
+{
+  options.systemModules.shell.fish.enable = mkEnableOption "Enable fish module";
+
+  config = mkIf (adminShell == "fish" || cfg.enable) {
+    programs.fish = {
+      enable = true;
+      vendor = {
+        completions.enable = true;
+        config.enable = true;
+        functions.enable = true;
+      };
+    };
+  };
+}

system/modules/shell/zsh/default.nix

@@ -0,0 +1,25 @@
+{ lib, config, ... }:
+
+let
+  inherit (lib) mkIf mkEnableOption;
+  adminShell = config.systemModules.host.admin.shell;
+  cfg = config.systemModules.shell.zsh;
+in
+
+{
+
+  options.systemModules.zsh.enable = mkEnableOption "Enable zsh module";
+
+  config = mkIf (adminShell == "zsh" || cfg.enable) {
+    programs.zsh = {
+      enable = true;
+      enableCompletion = true;
+      syntaxHighlighting.enable = true;
+      autosuggestions = {
+        enable = true;
+        async = true;
+      };
+    };
+    environment.pathsToLink = ["/share/zsh"];
+  };
+}

system/modules/user/shell/default.nix

@@ -1,19 +0,0 @@
-{ lib, ... }:
-
-let
-  inherit (lib) types mkOption;
-in
-
-{
-  imports = [
-    ./fish
-    ./bash
-    ./zsh
-  ];
-
-  options.systemModules.user.shell = mkOption {
-    type = types.enum ["fish" "zsh" "bash"];
-    default = "zsh";
-    description = "The user shell to use. Select from 'zsh' 'bash' 'fish'";
-  };
-}

system/modules/user/shell/fish/default.nix

@@ -1,20 +0,0 @@
-{ pkgs, lib, config, ... }:
-
-let
-  inherit (lib) mkIf;
-  userShell = config.systemModules.user.shell;
-in
-
-{
-  config = mkIf (userShell == "fish") {
-    users.users.ooks.shell = pkgs.fish;
-    programs.fish = {
-      enable = true;
-      vendor = {
-        completions.enable = true;
-        config.enable = true;
-        functions.enable = true;
-      };
-    };
-  };
-}

system/modules/user/shell/zsh/default.nix

@@ -1,22 +0,0 @@
-{ lib, config, pkgs, ... }:
-
-let
-  inherit (lib) mkIf;
-  userShell = config.systemModules.user.shell;
-in
-
-{
-  config = mkIf (userShell == "zsh") {
-    users.users.ooks.shell = pkgs.zsh;
-    programs.zsh = {
-      enable = true;
-      enableCompletion = true;
-      syntaxHighlighting.enable = true;
-      autosuggestions = {
-        enable = true;
-        async = true;
-      };
-    };
-    environment.pathsToLink = ["/share/zsh"];
-  };
-}